Login | Register
My pages Projects Community openCollabNet

Discussions > users > Re: Issue Tracker Plugin and Recent Messages

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Back to topic list

Re: Issue Tracker Plugin and Recent Messages

Author steveking
Full name Stefan Küng
Date 2009-01-06 10:27:09 PST
Message David Henderson wrote:
> Hi Stefan,
>
> I've just found a small bug in the issue tracker implementation (that
> you did some work on in early December):
>
> To reproduce (using yesterday's nightly build):
>
> 1) Do 1 commit with a BugzID using the issue tracker plug-in.
> 2) Open the commit dialog for a second commit
> 3) Click the recent messages button and select the previous message.
> The Issue box will be filled with the value from the previous entry.
> 4) Click OK. The message "Only Numbers (optionally separated by commas)
> are allowed!" will be shown in a tooltip.
>
> There are no characters before or after the number in the box. To
> complete the commit, you need to make a change within the issue # box.

Strange. I can't reproduce this.
Also, the code responsible for the check gets the text from the edit box
directly, not from a variable:

    CString id;
    GetDlgItemText(IDC_BUGID, id);
    if (!m_ProjectPropertie​s.CheckBugID(id))
    {
        ShowBalloon(IDC_BUGID, IDS_COMMITDLG_ONLYNUMBERS, IDI_EXCLAMATION);
        return;
    }

which means that if the text is shown in the issue # box, it will be
used and it should not be necessary to edit the text in there first.

Stefan

--
       ___
  oo // \\ "De Chelonian Mobile"
 (_,\/ \_/ \ TortoiseSVN
   \ \_/_\_/> The coolest Interface to (Sub)Version Control
   /_/ \_\ http://tortoisesvn.net
Attachments

« Previous message in topic | 8 of 10 | Next message in topic »

Messages

Show all messages in topic

Issue Tracker Plugin and bugtraq:warnifnoissue "David Henderson" <dhenderson at smartFOCUS dot com> "David Henderson" <dhenderson at smartFOCUS dot com> 2008-12-02 04:16:52 PST
     Re: Issue Tracker Plugin and bugtraq:warnifnoissue steveking Stefan Küng 2008-12-02 09:24:43 PST
         Re: Issue Tracker Plugin and bugtraq:warnifnoissue steveking Stefan Küng 2008-12-02 12:07:10 PST
             Issue Tracker Plugin and bugtraq:warnifnoissue "David Henderson" <dhenderson at smartFOCUS dot com> "David Henderson" <dhenderson at smartFOCUS dot com> 2008-12-03 01:13:41 PST
                 Re: Issue Tracker Plugin and bugtraq:warnifnoissue steveking Stefan Küng 2008-12-03 10:35:45 PST
                     Issue Tracker Plugin and bugtraq:warnifnoissue "David Henderson" <dhenderson at smartFOCUS dot com> "David Henderson" <dhenderson at smartFOCUS dot com> 2008-12-04 00:49:38 PST
                         Issue Tracker Plugin and Recent Messages "David Henderson" <dhenderson at smartFOCUS dot com> "David Henderson" <dhenderson at smartFOCUS dot com> 2009-01-06 06:58:25 PST
                             Re: Issue Tracker Plugin and Recent Messages steveking Stefan Küng 2009-01-06 10:27:09 PST
                                 RE: Issue Tracker Plugin and Recent Messages "David Henderson" <dhenderson at smartFOCUS dot com> "David Henderson" <dhenderson at smartFOCUS dot com> 2009-01-08 03:47:44 PST
                                     RE: Issue Tracker Plugin and Recent Messages "David Henderson" <dhenderson at smartFOCUS dot com> "David Henderson" <dhenderson at smartFOCUS dot com> 2009-01-08 06:27:27 PST
Messages per page: