Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: Suggestion: an additional hook script example.

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Back to topic list

Re: Suggestion: an additional hook script example.

Author steveking
Full name Stefan Küng
Date 2010-05-07 13:28:44 PDT
Message On 07.05.2010 22:19, Serge Tumanyan wrote:
> Stefan,
>
>>> I suggest an additional script hook example for you.
>> Sure, just commit it to the contrib folder. If you have a readme file
>> add that one too. If not, make sure you have enough comments in the hook
>> script file for others to understand what's it for.
>
> Done in the following path:
> contrib\hook-script​s\client-side\ReCo​mpileJAWSScriptsWC.j​s
>
> The only thing I want to ask you to do with it is to open it in any text
> editor and to check that I have formatted the tutorial comment at the
> beginning of the script correctly for the case if any of sighted people will
> look into it. I tryed to do this - but this is usually a problem with a
> screen reader. If I have made any formatting mistakes like wrong indentation
> or the comment looks not very attractive please feel free to modify it to
> gain attractive view.

The script looks good, as does the formatting.
Just one line I'll commit a change to soon: I'll split line 12 into two
lines, otherwise it gets too long.

Another small detail:
You've added the line
"for non-commercial use only."
wouldn't it be better to just say "Licensed under GNU GPL v2" or
something like that?

Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest Interface to (Sub)Version Control
    /_/ \_\ http://tortoisesvn.net

« Previous message in topic | 4 of 5 | Next message in topic »

Messages

Show all messages in topic

Suggestion: an additional hook script example. tumanyan Serge Tumanyan 2010-05-06 13:01:49 PDT
     Re: Suggestion: an additional hook script example. steveking Stefan Küng 2010-05-07 11:04:29 PDT
     Re: Suggestion: an additional hook script example. tumanyan Serge Tumanyan 2010-05-07 13:19:58 PDT
         Re: Suggestion: an additional hook script example. steveking Stefan Küng 2010-05-07 13:28:44 PDT
     Re: Suggestion: an additional hook script example. tumanyan Serge Tumanyan 2010-05-07 13:36:59 PDT
Messages per page: