Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: New patch

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Back to topic list

Re: New patch

Author steveking
Full name Stefan Küng
Date 2010-05-31 11:50:00 PDT
Message On 31.05.2010 08:41, Hans-Emil Skogh wrote:

> I'm not talking about how it is done "behind the scenes", only how it
> will appear to the end user. I don't see any problem with running the
> "patch all" (or to patch an individual file) execution from within the
> (not yet existing) patch dialog. Or if that feels awkward, do it in a
> single (preferably non-visible) tortoise merge instance in the
> background. Is there a particular reason that the patch-code is located
> in TMerge?

Yes: we had our own patch code which has nothing to do with svn. So I
implemented it in TMerge, because that's also where patches get applied.

> The only time a tortoise merge window would need to be created would be
> (as in "Changed Files") when a user wants to view a diff, and the
> slowdown of starting a new TMerge instance in those cases is OK, I'd
> say. (We do not share the same TMerge instance for "Changed Files" or
> for the "Log Messages" dialog.)

And that would require to start a TMerge instance.
Sure, we could change it to do so, but I don't like that idea.

Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest Interface to (Sub)Version Control
    /_/ \_\ http://tortoisesvn.net

« Previous message in topic | 2 of 2 | Next message in topic »

Messages

Show all messages in topic

Re: New patch "Hans-Emil Skogh" <Hans-Emil dot Skogh at tritech dot se> "Hans-Emil Skogh" <Hans-Emil dot Skogh at tritech dot se> 2010-05-30 23:42:23 PDT
     Re: New patch steveking Stefan Küng 2010-05-31 11:50:00 PDT
Messages per page: