Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: Checked TortoiseSVNs code with cppcheck

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

2020-03-13: This site is going to be decommissioned and shut down very soon. Please copy and archive any data you wish to keep ASAP

Back to topic list

Re: Checked TortoiseSVNs code with cppcheck

Author Stefan dot Fuhrmann at etas dot com
Full name Stefan dot Fuhrmann at etas dot com
Date 2010-10-04 04:50:18 PDT
Message "Philipp K." <philipp dot kloke at web dot de> wrote:

> I used cppcheck to analyze the source code of TortoiseSVN.
> Cppcheck claims to have found three errors and some style problems
> (I highlighted the errors with "->> " to make it easier for you to find
them in
> the long list because they are probably more important than the style
annotations.)

Hi Philipp,

thanks for running the analysis. I will see what can done reasonably
for the style issues.

As for the errors, only the one in TortoisePLink seems to be valid.
An fclose(fp) should be added here but I can't test that here.

The error reported for zlib is not an error because destroy(s) will
also free s->path and the code dereferencing the NULL pointer
in CrashCommand has been put there deliberately.

-- Stefan^2

« Previous message in topic | 2 of 2 | Next message in topic »

Messages

Show all messages in topic

Checked TortoiseSVNs code with cppcheck pkeus Philipp K. 2010-10-03 11:06:59 PDT
     Re: Checked TortoiseSVNs code with cppcheck Stefan dot Fuhrmann at etas dot com Stefan dot Fuhrmann at etas dot com 2010-10-04 04:50:18 PDT
Messages per page: