Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [T-Merge patch] syncing code for views

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Back to topic list

Re: [T-Merge patch] syncing code for views

Author steveking
Full name Stefan Küng
Date 2011-04-07 10:16:41 PDT
Message On 07.04.2011 00:11, Oto BREZINA wrote:
> Part3:
>
> prepend object name to simplify comparison/extraction common code
> use HasSelection() where aplicable
> Bottom: reorder viewstate triplet to order as used in LeftView and RightView
> Left: rename temporary variable from state2 to state
> Right: move SetModified out of for cycle

Committed in r21118.

> Note: by comparing LeftView, RightView and BottomView you can get nice overview about common part and differences
>
> In LeftView there are two BuildAllScreen2ViewVector(); RecalcAllVertScrollBars();, while in RightView on same place there are not those calls. Also not sure if they may be outside if (e.g. m_pwndLocator->Do​cumentUpdated(); is affected).

Fixed in r21119.

> sometime if (m_pwndBottom->Is​ViewLineConflicted(v​iewLine)) is used while on other places not.

It's used whenever the bottom view is visible. Or do you see another place?

Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest Interface to (Sub)Version Control
    /_/ \_\ http://tortoisesvn.net

« Previous message in topic | 7 of 27 | Next message in topic »

Messages

Show all messages in topic

[T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-04 13:57:21 PDT
     Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-05 11:03:39 PDT
         Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-05 14:10:14 PDT
             Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-06 09:26:00 PDT
                 Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-09 12:54:25 PDT
             Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-06 15:12:10 PDT
                 Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-07 10:16:41 PDT
                     Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-07 12:03:24 PDT
                         Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-07 12:42:35 PDT
                             Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-07 13:20:49 PDT
                                 Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-07 13:30:40 PDT
                                     Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-07 15:23:20 PDT
                                         Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-08 12:01:02 PDT
                                             Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-08 13:10:05 PDT
                                                 Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-09 00:17:09 PDT
                                                     Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-09 06:50:02 PDT
         Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-17 00:31:07 PDT
             Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-17 02:46:45 PDT
                 Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-05-11 13:54:50 PDT
                     Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-05-12 12:52:58 PDT
     Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-10 02:14:27 PDT
     Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-10 02:15:30 PDT
         Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-10 12:08:55 PDT
             Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-10 12:14:39 PDT
                 Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-10 12:22:04 PDT
Page: of 2 « Previous | Next »
Messages per page: