Login | Register
My pages Projects Community openCollabNet

Discussions > dev > encrypting credentials is done plain wrong

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Back to topic list

encrypting credentials is done plain wrong

Author wipedout
Full name Dmitry
Date 2011-04-13 02:16:23 PDT
Message Hey.

r21144 introduces some security measures that are intended to make credentials sniffing more difficult. That's snake oil. The key problem is that CString and other similar classes are totally unsuitable for storing sensitive data - see this http://stackoverflow​.com/questions/37855​82/how-to-write-a-pa​ssword-safe-class and this http://stackoverflow​.com/questions/37853​66/how-to-ensure-tha​t-compiler-optimizat​ions-dont-introduce-​a-security-risk for example, because they copy the string body in uncontrolled manner and don't overwrite the body once the string is no longer needed, so the program memory will be filled with gazillions of copies of a string before the program even knows.

My point is no encryption of program data makes any sense while unsuitable classes like CString are used for data manipulation. The first change should be replacing those classes with something that follows "use, then erase" strategy, then it'd make sense to use encryption. With current implementation the program stores one encrypted copy and an unknown number of unencrypted copies of the same string the program won't even think of.

Best wishes.
Dmitry.

« Previous message in topic | 1 of 10 | Next message in topic »

Messages

Show all messages in topic

encrypting credentials is done plain wrong wipedout Dmitry 2011-04-13 02:16:23 PDT
     Re: encrypting credentials is done plain wrong steveking Stefan Küng 2011-04-13 02:44:06 PDT
         Re: encrypting credentials is done plain wrong wipedout Dmitry 2011-04-13 23:11:57 PDT
             RE: Re: encrypting credentials is done plain wrong klimax Daniel Klima 2011-04-14 14:07:19 PDT
                 Re: encrypting credentials is done plain wrong wipedout Dmitry 2011-04-14 23:01:12 PDT
                     RE: Re: encrypting credentials is done plain wrong klimax Daniel Klima 2011-04-15 02:13:31 PDT
                         Re: Re: encrypting credentials is done plain wrong simonlarge Simon Large 2011-04-15 02:51:29 PDT
                             RE: Re: Re: encrypting credentials is done plain wrong klimax Daniel Klima 2011-04-15 13:19:43 PDT
                                 Re: encrypting credentials is done plain wrong steveking Stefan Küng 2011-04-15 13:23:07 PDT
                                     RE: Re: encrypting credentials is done plain wrong klimax Daniel Klima 2011-04-15 23:12:44 PDT
Messages per page: