Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged....

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Back to topic list

Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged....

Author Daniel Becroft <djcbecroft at gmail dot com>
Full name Daniel Becroft <djcbecroft at gmail dot com>
Date 2011-04-22 20:50:24 PDT
Message On Sat, Apr 23, 2011 at 4:38 AM, Stefan Küng <tortoisesvn at gmail dot com> wrote:

> On 22.04.2011 20:25, Oto BREZINA wrote:
> > On 2011-04-22 19:10, Stefan Küng wrote:
> >> On 22.04.2011 14:42, Oto BREZINA wrote:
> >>> What was reason for this rename ?
> >> Grammar. Though I'm not a native English speaker, I'm pretty sure that
> >> the method 'has' is correct here.
> > Thought that, even I was "sure" that 'is' is right. In fact in our
> > company we use just 'is' as only question in method name (till now :) ).
> > My English is easy ;) Take it easy :D
>
> Hey, I didn't say you did it wrong. It just didn't 'feel' right with
> that name :)
>

As a native english speaker (well, Australian), "HasSourceFileChanged" is
correct for a method name (since it implies an action of some sort). If it
were a property (which is an attribute), I'd expect "IsSourceFileChanged".

It's a subtle difference. Another way to think about it is: Is the train
here? vs Has the train arrived?

Cheers,
Daniel B.
Attachments

« Previous message in topic | 6 of 6 | Next message in topic »

Messages

Show all messages in topic

Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged.... otik Oto BREZINA 2011-04-22 05:42:52 PDT
     Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged.... otik Oto BREZINA 2011-04-22 09:31:52 PDT
     Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged.... steveking Stefan Küng 2011-04-22 10:10:35 PDT
         Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged.... otik Oto BREZINA 2011-04-22 11:25:42 PDT
             Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged.... steveking Stefan Küng 2011-04-22 11:38:49 PDT
                 Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged.... Daniel Becroft <djcbecroft at gmail dot com> Daniel Becroft <djcbecroft at gmail dot com> 2011-04-22 20:50:24 PDT
Messages per page: