Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: Suggestion: an additional hook script example.

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Hide all messages in topic

All messages in topic

Re: Suggestion: an additional hook script example.

Author tumanyan
Full name Serge Tumanyan
Date 2010-05-07 13:36:59 PDT
Message Stefan,

> The script looks good, as does the formatting.
> Just one line I'll commit a change to soon: I'll split line 12 into two
> lines, otherwise it gets too long.
> Another small detail:
> You've added the line
> "for non-commercial use only."
> wouldn't it be better to just say "Licensed under GNU GPL v2" or
> something like that?

Sure, I am not very fluent in all these licencies yet, so you can change
this too.

Serge.

Re: Suggestion: an additional hook script example.

Author steveking
Full name Stefan Küng
Date 2010-05-07 13:28:44 PDT
Message On 07.05.2010 22:19, Serge Tumanyan wrote:
> Stefan,
>
>>> I suggest an additional script hook example for you.
>> Sure, just commit it to the contrib folder. If you have a readme file
>> add that one too. If not, make sure you have enough comments in the hook
>> script file for others to understand what's it for.
>
> Done in the following path:
> contrib\hook-script​s\client-side\ReCo​mpileJAWSScriptsWC.j​s
>
> The only thing I want to ask you to do with it is to open it in any text
> editor and to check that I have formatted the tutorial comment at the
> beginning of the script correctly for the case if any of sighted people will
> look into it. I tryed to do this - but this is usually a problem with a
> screen reader. If I have made any formatting mistakes like wrong indentation
> or the comment looks not very attractive please feel free to modify it to
> gain attractive view.

The script looks good, as does the formatting.
Just one line I'll commit a change to soon: I'll split line 12 into two
lines, otherwise it gets too long.

Another small detail:
You've added the line
"for non-commercial use only."
wouldn't it be better to just say "Licensed under GNU GPL v2" or
something like that?

Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest Interface to (Sub)Version Control
    /_/ \_\ http://tortoisesvn.net

Re: Suggestion: an additional hook script example.

Author tumanyan
Full name Serge Tumanyan
Date 2010-05-07 13:19:58 PDT
Message Stefan,

>> I suggest an additional script hook example for you.
> Sure, just commit it to the contrib folder. If you have a readme file
> add that one too. If not, make sure you have enough comments in the hook
> script file for others to understand what's it for.

Done in the following path:
contrib\hook-script​s\client-side\ReCo​mpileJAWSScriptsWC.j​s

The only thing I want to ask you to do with it is to open it in any text
editor and to check that I have formatted the tutorial comment at the
beginning of the script correctly for the case if any of sighted people will
look into it. I tryed to do this - but this is usually a problem with a
screen reader. If I have made any formatting mistakes like wrong indentation
or the comment looks not very attractive please feel free to modify it to
gain attractive view.

Thank you.

Serge.

Re: Suggestion: an additional hook script example.

Author steveking
Full name Stefan Küng
Date 2010-05-07 11:04:29 PDT
Message On 06.05.2010 22:01, Serge Tumanyan wrote:
> Hello, All.
>
> I suggest an additional script hook example for you.
> Features:
> 1. a simple js script.
> 2. Recompiles the updated scripts just in place the working copy is intended
> to be - in the user folder of JAWS.
> 3. Short step by step instruction at the beggining of the script.
> 4. The script recompiles the JAWS scripts depending on version of JAWS
> taking this information from the path it is placed in.
> 5. The script is announcing the revision and the active WC directory,
> compiles the script and announces the end of compilation through the active
> SAPI 5 voice.
>
> I use this script for some time already and fond of it. If you are
> interested please let me know if this script should be committed in the hook
> examples folder or to the screen readers one - I suggest to the hook script
> examples - it is a good example for a lot of unusual abilities of hook
> scripts.

Sure, just commit it to the contrib folder. If you have a readme file
add that one too. If not, make sure you have enough comments in the hook
script file for others to understand what's it for.

Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest Interface to (Sub)Version Control
    /_/ \_\ http://tortoisesvn.net

Suggestion: an additional hook script example.

Author tumanyan
Full name Serge Tumanyan
Date 2010-05-06 13:01:49 PDT
Message Hello, All.

I suggest an additional script hook example for you.
Features:
1. a simple js script.
2. Recompiles the updated scripts just in place the working copy is intended
to be - in the user folder of JAWS.
3. Short step by step instruction at the beggining of the script.
4. The script recompiles the JAWS scripts depending on version of JAWS
taking this information from the path it is placed in.
5. The script is announcing the revision and the active WC directory,
compiles the script and announces the end of compilation through the active
SAPI 5 voice.

I use this script for some time already and fond of it. If you are
interested please let me know if this script should be committed in the hook
examples folder or to the screen readers one - I suggest to the hook script
examples - it is a good example for a lot of unusual abilities of hook
scripts.

Thank you.

Serge.
Messages per page: