Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged....

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Hide all messages in topic

All messages in topic

Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged....

Author Daniel Becroft <djcbecroft at gmail dot com>
Full name Daniel Becroft <djcbecroft at gmail dot com>
Date 2011-04-22 20:50:24 PDT
Message On Sat, Apr 23, 2011 at 4:38 AM, Stefan Küng <tortoisesvn at gmail dot com> wrote:

> On 22.04.2011 20:25, Oto BREZINA wrote:
> > On 2011-04-22 19:10, Stefan Küng wrote:
> >> On 22.04.2011 14:42, Oto BREZINA wrote:
> >>> What was reason for this rename ?
> >> Grammar. Though I'm not a native English speaker, I'm pretty sure that
> >> the method 'has' is correct here.
> > Thought that, even I was "sure" that 'is' is right. In fact in our
> > company we use just 'is' as only question in method name (till now :) ).
> > My English is easy ;) Take it easy :D
>
> Hey, I didn't say you did it wrong. It just didn't 'feel' right with
> that name :)
>

As a native english speaker (well, Australian), "HasSourceFileChanged" is
correct for a method name (since it implies an action of some sort). If it
were a property (which is an attribute), I'd expect "IsSourceFileChanged".

It's a subtle difference. Another way to think about it is: Is the train
here? vs Has the train arrived?

Cheers,
Daniel B.
Attachments

Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged....

Author steveking
Full name Stefan Küng
Date 2011-04-22 11:38:49 PDT
Message On 22.04.2011 20:25, Oto BREZINA wrote:
> On 2011-04-22 19:10, Stefan Küng wrote:
>> On 22.04.2011 14:42, Oto BREZINA wrote:
>>> What was reason for this rename ?
>> Grammar. Though I'm not a native English speaker, I'm pretty sure that
>> the method 'has' is correct here.
> Thought that, even I was "sure" that 'is' is right. In fact in our
> company we use just 'is' as only question in method name (till now :) ).
> My English is easy ;) Take it easy :D

Hey, I didn't say you did it wrong. It just didn't 'feel' right with
that name :)

> Just wonder, how you call variable containing number of bytes you get by
> reading?
> nBytesRead or nBytesReaded ?
> I have used second naturaly and have seen it also in some libs we used.

nBytesRead.

the past tense of read is read. (pronounced differently but written the
same).

Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest Interface to (Sub)Version Control
    /_/ \_\ http://tortoisesvn.net

Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged....

Author otik
Full name Oto BREZINA
Date 2011-04-22 11:25:42 PDT
Message On 2011-04-22 19:10, Stefan Küng wrote:
> On 22.04.2011 14:42, Oto BREZINA wrote:
>> What was reason for this rename ?
> Grammar. Though I'm not a native English speaker, I'm pretty sure that
> the method 'has' is correct here.
Thought that, even I was "sure" that 'is' is right. In fact in our
company we use just 'is' as only question in method name (till now :) ).
My English is easy ;) Take it easy :D

Just wonder, how you call variable containing number of bytes you get by
reading?
nBytesRead or nBytesReaded ?
I have used second naturaly and have seen it also in some libs we used.
> Stefan
>

--
Oto BREZINA, Printflow s.r.o., EU

Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged....

Author steveking
Full name Stefan Küng
Date 2011-04-22 10:10:35 PDT
Message On 22.04.2011 14:42, Oto BREZINA wrote:
> On 2011-04-21 19:39, tortoisesvn at googlecode dot com wrote:
>> Revision: 21200
>> Author: tortoisesvn
>> Date: Thu Apr 21 10:39:11 2011
>> Log: * Rename the method IsSourceFileChanged to HasSourceFileChanged.
> What was reason for this rename ?

Grammar. Though I'm not a native English speaker, I'm pretty sure that
the method 'has' is correct here.

Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest Interface to (Sub)Version Control
    /_/ \_\ http://tortoisesvn.net

Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged....

Author otik
Full name Oto BREZINA
Date 2011-04-22 09:31:52 PDT
Message On 2011-04-22 14:42, Oto BREZINA wrote:
> On 2011-04-21 19:39, tortoisesvn at googlecode dot com wrote:
>> Revision: 21200
>> Author: tortoisesvn
>> Date: Thu Apr 21 10:39:11 2011
>> Log: * Rename the method IsSourceFileChanged to HasSourceFileChanged.
> What was reason for this rename ?
>
> Attached patch:
> * use attrib instead of separate attributes and remove HaveData
aaaand fix ...

--
Oto BREZINA, Printflow s.r.o., EU
Attachments

Re: [tortoisesvn] r21200 committed - * Rename the method IsSourceFileChanged to HasSourceFileChanged....

Author otik
Full name Oto BREZINA
Date 2011-04-22 05:42:52 PDT
Message On 2011-04-21 19:39, tortoisesvn at googlecode dot com wrote:
> Revision: 21200
> Author: tortoisesvn
> Date: Thu Apr 21 10:39:11 2011
> Log: * Rename the method IsSourceFileChanged to HasSourceFileChanged.
What was reason for this rename ?

Attached patch:
* use attrib instead of separate attributes and remove HaveData
--
Oto BREZINA, Printflow s.r.o., EU
Attachments
Messages per page: