Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: Maybe patch - group all actions on one view in BaseView

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Hide all messages in topic

All messages in topic

Re: Maybe patch - group all actions on one view in BaseView

Author wipedout
Full name Dmitry
Date 2011-04-28 01:54:01 PDT
Message Hey.

27.04.11, 10:26, "Oto BREZINA" <otik at printflow dot eu>:
> > Attaches is a maybe patch for code in BaseView. Currently operation goes like this "if view A is good, do action 1 on view A, then the same for views B and C, then if view A is good do action2 on view A, then the same for B and C". Is it possible to go like this: "is view A is good, do both 1 and 2, then proceed to B and also do 1 and 2, then same for C"? That would make further duplicaion reduction possible.
> Thanks, however:
> It would not work as build action2 needs 1 to be done for all views
> already. Anyway I hope that this is intermediate state only.

Okay, then attached is an untested patch that reduces duplication without altering control flow.

Best wishes.
Dmitry.
Attachments

Re: Maybe patch - group all actions on one view in BaseView

Author otik
Full name Oto BREZINA
Date 2011-04-26 23:26:43 PDT
Message On 2011-04-27 07:57, Dmitry wrote:
> Hey.
>
> Attaches is a maybe patch for code in BaseView. Currently operation goes like this "if view A is good, do action 1 on view A, then the same for views B and C, then if view A is good do action2 on view A, then the same for B and C". Is it possible to go like this: "is view A is good, do both 1 and 2, then proceed to B and also do 1 and 2, then same for C"? That would make further duplicaion reduction possible.
Thanks, however:
It would not work as build action2 needs 1 to be done for all views
already. Anyway I hope that this is intermediate state only.
--
Oto BREZINA, Printflow s.r.o., EU

Maybe patch - group all actions on one view in BaseView

Author wipedout
Full name Dmitry
Date 2011-04-26 22:57:33 PDT
Message Hey.

Attaches is a maybe patch for code in BaseView. Currently operation goes like this "if view A is good, do action 1 on view A, then the same for views B and C, then if view A is good do action2 on view A, then the same for B and C". Is it possible to go like this: "is view A is good, do both 1 and 2, then proceed to B and also do 1 and 2, then same for C"? That would make further duplicaion reduction possible.

Best wishes.
Dmitry.
Attachments
Messages per page: