Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: Request for improving tabbing on the Commit dialog

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Hide all messages in topic

All messages in topic

Re: Request for improving tabbing on the Commit dialog

Author rjollos
Full name Ryan J Ollos
Date 2011-08-08 19:40:55 PDT
Message Stefan Küng wrote:
>
> Possible, yes. But it would break all screen readers, which is not good
> for blind people.
>
> What I could do however is to move the links in the tab order after the
> file list control. But this would then make the tab order inconsistent
> with the 'UI order' of the control.
> Thoughts?
>
> Stefan
>

It seems best to keep the tab order consistent with the UI order. If there
are no other ways to solve this, then I think the shortcuts that Serge
described should certainly be adequate for having a good keyboard navigation
experience. I just need to figure out how I can go about learning what
shortcuts have been enabled (see comment in reply to Serge's post).

--
View this message in context: http://old.nabble.co​m/Request-for-improv​ing-tabbing-on-the-C​ommit-dialog-tp32206​308p32223179.html
Sent from the tortoisesvn - dev mailing list archive at Nabble.com.

Re: Request for improving tabbing on the Commit dialog

Author rjollos
Full name Ryan J Ollos
Date 2011-08-08 19:26:09 PDT
Message Serge Tumanyan wrote:
>
> The edit box has a Alt+E keyboard shortcut and the file list has the Alt+F
> -
> you will get to any of them with one keypress. Removing the controls from
> the Tab order is possible but to my personal opinion is not the best idea.
> Per my request Stefan added accessibility support to the TSVN (I am
> personally totally blind) and when the blind person tabs over the controls
> he can miss that some of the controls can be focused though they are not
> in
> the tab order. In addition a lot of the keyboard shortcuts were added due
> to
> my accessibility requests to help me handle the workflow as fast as
> possible. So you can use them for keyboard control of the process.
>
> Serge.
>

Using the ALT keyboard shortcuts sounds like a good solution, but is there a
way for me to know which shortcuts are enabled for the various dialog boxes?
I don't see these documented anywhere.

Assuming they aren't documented, what would be a good way to document them?
A page in the help doesn't seem all that useful.

Two ways I've seen for showing the keyboard shortcuts are:
 - An entry displayed next to a menu item (seems not too applicable in this
case).
 - When holding down the ALT key in Outlook, letters are displayed over the
items (see screen capture below).

http://old.nabble.co​m/file/p32223137/Out​look.png Outlook.png

--
View this message in context: http://old.nabble.co​m/Request-for-improv​ing-tabbing-on-the-C​ommit-dialog-tp32206​308p32223137.html
Sent from the tortoisesvn - dev mailing list archive at Nabble.com.

Re: Request for improving tabbing on the Commit dialog

Author tumanyan
Full name Serge Tumanyan
Date 2011-08-06 04:16:35 PDT
Message Hello, Stefan.

> What I could do however is to move the links in the tab order after the
> file list control. But this would then make the tab order inconsistent
> with the 'UI order' of the control.
> Thoughts?

I do not think it to be a good idea. There are a lot of keyboard shortcuts
like Alt+E and Alt+F for the edit box and for file list that should be
enouth for quick navigation by the keyboard. At least I am using them all
over the time and have a very fast navigation between the controls -
remember I am unable to use a mouse, so my expirience in the keyboard
navigation is quite good.

Thank you.

Serge.

Re: Request for improving tabbing on the Commit dialog

Author tumanyan
Full name Serge Tumanyan
Date 2011-08-06 04:16:33 PDT
Message Hello, Ryan.

> An issue (for myself at least) with the 1.7 Commit dialog is that it
> typically requires 8 or more tab key presses to go from the Log Message
> text
> box in the upper pane, to the file list control in the bottom pane. One
> must
> now tab through all of the checkbox controls (All | None | Non-Versioned |
> ... )
>
> With TSVN 1.6, only one tab keypress was required to jump from the Log
> message textbox to the File list list control. This is a pretty integral
> part of my workflow - type the log message, hit tab to jump to file list
> pane, and then start reviewing the changesets, all using keypresses.
>
> Would it be possible to put all of the checkbox controls in some sort of
> panel that such that 1 tab key press would take you from the Log message
> box
> to a panel containing the checkbox controls, and a second tab key press
> would take you to the file list pane? When in the panel (pane?) containing
> the checkbox controls, the arrow keys could be used to navigate among the
> checkbox controls.

The edit box has a Alt+E keyboard shortcut and the file list has the Alt+F -
you will get to any of them with one keypress. Removing the controls from
the Tab order is possible but to my personal opinion is not the best idea.
Per my request Stefan added accessibility support to the TSVN (I am
personally totally blind) and when the blind person tabs over the controls
he can miss that some of the controls can be focused though they are not in
the tab order. In addition a lot of the keyboard shortcuts were added due to
my accessibility requests to help me handle the workflow as fast as
possible. So you can use them for keyboard control of the process.

Serge.

Re: Request for improving tabbing on the Commit dialog

Author steveking
Full name Stefan Küng
Date 2011-08-06 01:30:37 PDT
Message On 06.08.2011 02:46, Ryan J Ollos wrote:
> I'm currently testing build 21779.
>
> An issue (for myself at least) with the 1.7 Commit dialog is that it
> typically requires 8 or more tab key presses to go from the Log Message text
> box in the upper pane, to the file list control in the bottom pane. One must
> now tab through all of the checkbox controls (All | None | Non-Versioned |
> ... )
>
> With TSVN 1.6, only one tab keypress was required to jump from the Log
> message textbox to the File list list control. This is a pretty integral
> part of my workflow - type the log message, hit tab to jump to file list
> pane, and then start reviewing the changesets, all using keypresses.
>
> Would it be possible to put all of the checkbox controls in some sort of
> panel that such that 1 tab key press would take you from the Log message box
> to a panel containing the checkbox controls, and a second tab key press
> would take you to the file list pane? When in the panel (pane?) containing
> the checkbox controls, the arrow keys could be used to navigate among the
> checkbox controls.
>
> Here is a screen shot demonstrating what I mean. Group all of the circled
> checkboxes into a panel that allows navigating among the items with the
> arrow keys, and the panel could be "skipped-over" with one tab key press.
>
> http://old.nabble.co​m/file/p32206308/Com​mitDialog.png
>
> I'm not familiar with the Windows UI so I don't know if this is possible,
> and sorry if this request is confusing due to my not being familiar with the
> proper UI terminology ;)

Possible, yes. But it would break all screen readers, which is not good
for blind people.

What I could do however is to move the links in the tab order after the
file list control. But this would then make the tab order inconsistent
with the 'UI order' of the control.
Thoughts?

Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest Interface to (Sub)Version Control
    /_/ \_\ http://tortoisesvn.net

Request for improving tabbing on the Commit dialog

Author rjollos
Full name Ryan J Ollos
Date 2011-08-05 17:46:59 PDT
Message I'm currently testing build 21779.

An issue (for myself at least) with the 1.7 Commit dialog is that it
typically requires 8 or more tab key presses to go from the Log Message text
box in the upper pane, to the file list control in the bottom pane. One must
now tab through all of the checkbox controls (All | None | Non-Versioned |
... )

With TSVN 1.6, only one tab keypress was required to jump from the Log
message textbox to the File list list control. This is a pretty integral
part of my workflow - type the log message, hit tab to jump to file list
pane, and then start reviewing the changesets, all using keypresses.

Would it be possible to put all of the checkbox controls in some sort of
panel that such that 1 tab key press would take you from the Log message box
to a panel containing the checkbox controls, and a second tab key press
would take you to the file list pane? When in the panel (pane?) containing
the checkbox controls, the arrow keys could be used to navigate among the
checkbox controls.

Here is a screen shot demonstrating what I mean. Group all of the circled
checkboxes into a panel that allows navigating among the items with the
arrow keys, and the panel could be "skipped-over" with one tab key press.

http://old.nabble.co​m/file/p32206308/Com​mitDialog.png

I'm not familiar with the Windows UI so I don't know if this is possible,
and sorry if this request is confusing due to my not being familiar with the
proper UI terminology ;)

Thanks!
--
View this message in context: http://old.nabble.co​m/Request-for-improv​ing-tabbing-on-the-C​ommit-dialog-tp32206​308p32206308.html
Sent from the tortoisesvn - dev mailing list archive at Nabble.com.
Messages per page: