Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Trunk build: redefinition errors on CrashHandler SendRpt

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Hide all messages in topic

All messages in topic

Re: Trunk build: redefinition errors on CrashHandler SendRpt

Author julianfoad
Full name Julian Foad
Date 2017-09-04 10:36:48 PDT
Message Stefan Hett wrote:
> On 9/4/2017 1:54 PM, Julian Foad wrote:
>> Compiling fails for me on the CrashHandler, with many errors all of
>> the following form:
>>
> Just tried it with a fresh VS2017 installation. Same issue here. My
> workaround for the problem is to simply add the following include to
> \ext\CrashServer\​CrashHandler\SendRp​t\stdafx.h:
>
> #include <WinSock2.h>
>
> (right above the asser.h-include).
>
> I didn't dig into the details what's exactly wrong there, but this does
> the trick to me.

... And steveking has just committed this change.

Thanks, both of you!

- Julian

Re: Trunk build: redefinition errors on CrashHandler SendRpt

Author steveking
Full name Stefan Küng
Date 2017-09-04 10:33:00 PDT
Message On 04.09.2017 18:05, Stefan Hett wrote:
> On 9/4/2017 1:54 PM, Julian Foad wrote:
>> Hello. I'm trying to compile TSVN for the first time ever, being
>> unfamiliar with compiling on Windows (last did it about 15 years ago),
>> and running into some trivial problem to which I don't know the
>> answer.
>>
>> Compiling fails for me on the CrashHandler, with many errors all of
>> the following form:
>>
>> [exec] C:\Program Files (x86)\Windows
>> Kits\8.1\Include\​shared\ws2def.h(221​): error C2011: 'sockaddr':
>> 'struct' type redefinition
>> [C:\jenkins\worksp​ace\TSVN_trunk\Tor​toiseSVN\ext\crash​server\CrashHandler​\SendRpt\SendRpt.v​cxproj]
>> [exec] C:\Program Files (x86)\Windows
>> Kits\8.1\Include\​um\winsock.h(1002):​ note: see declaration of
>> 'sockaddr'
>>
>> (This machine has both VS2015 and VS2017 installed, as I was also
>> trying to build TSVN 1.9.)
>>
>> Any ideas what's wrong, or what information I can provide to help
>> debug this, please?
>>
>> And is there an instant messaging channel we can use for quicker
>> communication on this?
>>
>> Thanks,
>> - Julian
>>
>> --------------------​--------------------​--------------
>> http://tortoisesvn.t​igris.org/ds/viewMes​sage.do?dsForumId=75​7&dsMessageId=32​97661
>>
>> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@tor​toisesvn.tigris.org]​.
>>
> Just tried it with a fresh VS2017 installation. Same issue here. My
> workaround for the problem is to simply add the following include to
> \ext\CrashServer\​CrashHandler\SendRp​t\stdafx.h:
>
> #include <WinSock2.h>
>
> (right above the asser.h-include).
>
> I didn't dig into the details what's exactly wrong there, but this does
> the trick to me.

Fixed in r27929.

Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest interface to (Sub)version control
    /_/ \_\ http://tortoisesvn.net

Re: Trunk build: redefinition errors on CrashHandler SendRpt

Author stefanego
Full name Stefan Hett
Date 2017-09-04 09:04:09 PDT
Message On 9/4/2017 1:54 PM, Julian Foad wrote:
> Hello. I'm trying to compile TSVN for the first time ever, being
> unfamiliar with compiling on Windows (last did it about 15 years ago),
> and running into some trivial problem to which I don't know the
> answer.
>
> Compiling fails for me on the CrashHandler, with many errors all of
> the following form:
>
> [exec] C:\Program Files (x86)\Windows
> Kits\8.1\Include\​shared\ws2def.h(221​): error C2011: 'sockaddr':
> 'struct' type redefinition
> [C:\jenkins\worksp​ace\TSVN_trunk\Tor​toiseSVN\ext\crash​server\CrashHandler​\SendRpt\SendRpt.v​cxproj]
> [exec] C:\Program Files (x86)\Windows
> Kits\8.1\Include\​um\winsock.h(1002):​ note: see declaration of
> 'sockaddr'
>
> (This machine has both VS2015 and VS2017 installed, as I was also
> trying to build TSVN 1.9.)
>
> Any ideas what's wrong, or what information I can provide to help
> debug this, please?
>
> And is there an instant messaging channel we can use for quicker
> communication on this?
>
> Thanks,
> - Julian
>
> --------------------​--------------------​--------------
> http://tortoisesvn.t​igris.org/ds/viewMes​sage.do?dsForumId=75​7&dsMessageId=32​97661
>
> To unsubscribe from this discussion, e-mail: [dev-unsubscribe@tor​toisesvn.tigris.org]​.
>
Just tried it with a fresh VS2017 installation. Same issue here. My
workaround for the problem is to simply add the following include to
\ext\CrashServer\​CrashHandler\SendRp​t\stdafx.h:

#include <WinSock2.h>

(right above the asser.h-include).

I didn't dig into the details what's exactly wrong there, but this does
the trick to me.

--
Regards,
Stefan Hett

Trunk build: redefinition errors on CrashHandler SendRpt

Author julianfoad
Full name Julian Foad
Date 2017-09-04 04:53:30 PDT
Message Hello. I'm trying to compile TSVN for the first time ever, being
unfamiliar with compiling on Windows (last did it about 15 years ago),
and running into some trivial problem to which I don't know the
answer.

Compiling fails for me on the CrashHandler, with many errors all of
the following form:

[exec] C:\Program Files (x86)\Windows
Kits\8.1\Include\​shared\ws2def.h(221​): error C2011: 'sockaddr':
'struct' type redefinition
[C:\jenkins\worksp​ace\TSVN_trunk\Tor​toiseSVN\ext\crash​server\CrashHandler​\SendRpt\SendRpt.v​cxproj]
[exec] C:\Program Files (x86)\Windows
Kits\8.1\Include\​um\winsock.h(1002):​ note: see declaration of
'sockaddr'

(This machine has both VS2015 and VS2017 installed, as I was also
trying to build TSVN 1.9.)

Any ideas what's wrong, or what information I can provide to help
debug this, please?

And is there an instant messaging channel we can use for quicker
communication on this?

Thanks,
- Julian
Messages per page: