Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: [T-Merge patch] syncing code for views

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Back to topic list

Re: [T-Merge patch] syncing code for views

Author otik
Full name Oto BREZINA
Date 2011-04-05 14:10:14 PDT
Message On 2011-04-05 20:03, Stefan Küng wrote:
> On 04.04.2011 22:57, Oto BREZINA wrote:
>> Theme of patch: syncing code of BottomView.cpp, LeftView.cpp,
>> RightView.cpp for later refactor common part to (BaseView.cpp)
(same theme) part 2 attached : LeftView: extracting code from switch
into functions; RightView add spaces to match LeftView formating;
BaseView remove commented block defining WM_MOUSEHWHEEL fo pre 600 wins
>> popup.AppendMenu(
>> UINT nFlags,
>> UINT_PTR nIDNewItem = 0,
>> LPCTSTR lpszNewItem = NULL )
>>
>> 1. Is there any real gain to do not use nIDNewItem same value as IDS ?
> That depends on whether we trust the optimizations of the compiler :)
> If we use the IDS values, then the switch() could take up a lot of space
> since those values are not continuous or even in the same value range.
> Sure, we could edit the resource.h file manually to make sure those IDS
> values are as we would like them, but I don't like messing with
> generated files.
we are talking about user action response - called rare, with up to ten
values. No big deal, but I will keep in mind ...

> Stefan
>

--
Oto BREZINA, Printflow s.r.o., EU
Attachments

« Previous message in topic | 3 of 27 | Next message in topic »

Messages

Show all messages in topic

                     Re: [T-Merge patch] syncing code for views steveking Stefan Küng 2011-04-10 12:35:07 PDT
                         Re: [T-Merge patch] syncing code for views otik Oto BREZINA 2011-04-10 12:44:39 PDT
Page: of 2 « Previous | Next »
Messages per page: