Login | Register
My pages Projects Community openCollabNet

Discussions > dev > CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Back to topic list

CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit

Author willorix
Full name Jens Wilhelm
Date 2016-09-07 05:08:26 PDT
Message Hi,
testing a check_commit_hook - script I found an unexpected behaviar of the commit dialog.
My script returns an error and the dialog shows the errormessage. If I press abort, things go in the expected way. But if I press Esc on keyboard, commit is proceeding. I would say, this is an error.
In source I found that abort is done on a return value of 1 only (taskdlg.DoModal). Wouldn't it be better, only to proceed committing if the return value is 2?

Regards,
Willi

« Previous message in topic | 1 of 2 | Next message in topic »

Messages

Show all messages in topic

CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit willorix Jens Wilhelm 2016-09-07 05:08:26 PDT
     RE: CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit willorix Jens Wilhelm 2016-09-08 08:31:02 PDT
Messages per page: