Login | Register
My pages Projects Community openCollabNet

Discussions > dev > RE: CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Back to topic list

RE: CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit

Author willorix
Full name Jens Wilhelm
Date 2016-09-08 08:31:02 PDT
Message In other words:
/trunk/src/TortoiseP​roc/CommitDlg.cpp Rev. 27110 Line 537

I would replace:
  bool doIt = (taskdlg.DoModal(GetSafeHwnd()) == 1);
by:
  bool doIt = (taskdlg.DoModal(GetSafeHwnd()) != 2);

because doIt stands for abort.
Commit should only proceed if the user inputs "proceed ...". Cancelling taskdlg shoud not lead into commit.

Best regards

« Previous message in topic | 2 of 2 | Next message in topic »

Messages

Show all messages in topic

CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit willorix Jens Wilhelm 2016-09-07 05:08:26 PDT
     RE: CCommitDlg::OnOK - cancelling the TaskDialog after CheckCommit leads into an unwanted commit willorix Jens Wilhelm 2016-09-08 08:31:02 PDT
Messages per page: