Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: Restore selection list after applying filter

Project highlights: :. Download .: :. Support .: :. FAQ .: :. Translations .: :. Donate .: :. Report Bug .:

tortoisesvn
Discussion topic

Back to topic list

Re: Restore selection list after applying filter

Author steveking
Full name Stefan Küng
Date 2016-10-01 01:46:30 PDT
Message On 30.09.2016 12:51, Dani Soufi wrote:
> Dear devs,
>
> I encoutered recently an annoyance while working on a large project. I
> selected several commits to merge into a seperate branch, no problem
> there. Then I applied a filter to select some other commits, no problems
> there too. Now when I clear the filter, only the recently selected list
> is restored but my previous selection is deselected. Actually, the
> selection list is restored only for the current visible list and does
> not work for all the previous selects if the list was reloaded/filtered.
> This is a huge annoyance when you use alot of filtering, some selects
> will be lost and you need to keep track of them.
>
> That's why I submit a patch to fix this.
>
> The patch was developed and tested against r27333.

Thanks for the patch.
But I think this is the wrong way to approach the issue:
we already have something in place to restore selections/checkmarks.
Your patch introduces a second way to do that, and leaves the existing
one in place which leads to sometimes multiple restores.

I'll try to improve the restore some other way...

Stefan

--
        ___
   oo // \\ "De Chelonian Mobile"
  (_,\/ \_/ \ TortoiseSVN
    \ \_/_\_/> The coolest interface to (Sub)version control
    /_/ \_\ http://tortoisesvn.net

« Previous message in topic | 2 of 4 | Next message in topic »

Messages

Show all messages in topic

Restore selection list after applying filter Dani Soufi <danisoufi at gmail dot com> Dani Soufi <danisoufi at gmail dot com> 2016-09-30 03:51:38 PDT
     Re: Restore selection list after applying filter steveking Stefan Küng 2016-10-01 01:46:30 PDT
         Re: Restore selection list after applying filter Dani Soufi <danisoufi at gmail dot com> Dani Soufi <danisoufi at gmail dot com> 2016-10-01 05:00:44 PDT
             Re: Restore selection list after applying filter steveking Stefan Küng 2016-10-01 06:21:28 PDT
Messages per page: